sleep after reset before read register #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithTheEE
reviewed
Apr 17, 2023
| @@ -137,6 +138,7 @@ class SI7021: | |||
| def __init__(self, i2c_bus: I2C, address: int = 0x40) -> None: | |||
| self.i2c_device = I2CDevice(i2c_bus, address) | |||
| self._command(_RESET) | |||
| time.sleep(0.015) | |||
There was a problem hiding this comment.
Do you think adding a comment here to explain why there's a use of time.sleep() would be helpful?
There was a problem hiding this comment.
Yep, definitely. Latest comment adds a note with link back to the datasheet.
KeithTheEE
approved these changes
Apr 17, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 18, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#25 from DJDevon3/DJDevon3_IS31FL3741_Branch > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#24 from DJDevon3/DJDevon3_IS31FL3741_Branch Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 4.1.7 from 4.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#36 from FoamyGuy/sleep_after_reset > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #35
It turns out a sleep of only
0.015should be the longest that is needed, as specified in the datasheet (Thank you to @KeithTheEE and @jposada202020 !)I tested the change successfully on Raspberry Pi 3 B+ w/ Blinka and double checked it on a Feather S2 TFT to ensure the microcontroller behavior still works as expected.