Don't import Micropython framebuf in Circuitpython

[RetiredWizard]

fixes #83

I suspect the import of framebuf.mpy was intended to allow this library to be used in Micropython, not for the Micropython version of framebuf.mpy to be used in Circuitpython.

[dhalbert]

See #77 and #78. It was to get it to work with Blinka.

[RetiredWizard]

Ah, my last commit is probably still off the mark then... The first If should check for cpython. I'll update it again....

[RetiredWizard]

Well not being all that familiar with Blinka, I guess I should ask is it possible to use either the Micropython OR the Circuitpython version of framebuffer with this libarary when run under Blinka?

If so I should put the Try/Except block within the test for implementation.name == 'cpython' and only import adafruit_framebuf if the name is not 'cpython'.

[dhalbert]

Normally Blinka runs on top of CPython, but it can also run on top of MicroPython. (That was actually its very original use, but running on CPython became by far the more common use case.) So #77 is to be able to use the MicroPython framebuf when using this library with Blinka on top of MicroPython.

[RetiredWizard]

:laugh: Okay, so I need to check for all three cpython, micropython and circuitpython. I should probably also switch it so it trys the circuitpython library first when running under cpython.

Do you think this PR makes sense? I think the issue that initiated it, is also solved by simply removing the incompatible framebuf library from the device flash.

[RetiredWizard]

Well the Build CI doesn't like multiple imports so maybe I should just give up....

[dhalbert]

Let's see what is going on with the OP in #83.

[RetiredWizard]

I just saw your comment on the issue, that does change things a bit, this seems like much more of an edge case now and I've probably spent way too much time on it....

[dhalbert]

@RetiredWizard I'm closing this for now because the #83 problem may not be pervasive. We can always reopen it.