Skip to content

Fix for specifing image lib #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2018
Merged

Fix for specifing image lib #8

merged 2 commits into from
Oct 22, 2018

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Oct 22, 2018

Fixes #7

@kattni kattni requested a review from caternuson October 22, 2018 23:13
caternuson
caternuson approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@caternuson
Copy link
Contributor

Kitten BMPs were in a folder named images along with files named this.txt, .this_file, and ._this_mac_file. Tested with various flavors of specifying folder, all worked.

  • folder="images"
  • folder="/images"
  • folder="images/"
  • folder="/images/"

@caternuson caternuson merged commit fa1a8af into adafruit:master Oct 22, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 24, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@44d3b57)
4fa97de 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#18 from jerryneedell/jerryn_fix_pr_14
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#17 from jerryneedell/jerryn_None
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#8 from kattni/folder-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caternuson caternuson caternuson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattni @caternuson