Skip to content

Add missing type annotations #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2022
Merged

Add missing type annotations #38

merged 3 commits into from
Sep 3, 2022

Conversation

tcfranks
Copy link
Contributor

@tcfranks tcfranks commented Sep 2, 2022

resolves #36
submitted for review / comment

tekktrik
tekktrik requested changes Sep 2, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback below

tekktrik
tekktrik requested changes Sep 3, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave the wrong type return in my recommendation, my bad.

@tcfranks
Copy link
Contributor Author

tcfranks commented Sep 3, 2022

submitted for review of change

tekktrik
tekktrik approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tekktrik tekktrik merged commit b6cb1ab into adafruit:main Sep 3, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 4, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@51fe0e6)
47ec154 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.2.9 from 1.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#10 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.5.9 from 1.5.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#14 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.3.8 from 1.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#15 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.5.9 from 1.5.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#27 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.3.15 from 3.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#38 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_US100 to 1.1.13 from 1.1.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_US100#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.11.6 from 0.11.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#23 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6075 to 1.1.14 from 1.1.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6075#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.1.18 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#23 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik