-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
It's a warning about code duplication - it's a pylint warning describing that code is extremely similar and could probably be refactored. I don't think that's necessary here so we should just disable the warning. I'll get back to you on how to do so shortly, or may just push the change myself if that's okay, let me know |
either way is fine.....I was able to get local pylint (run on entire directory) to duplicate the error but not suppress it. That was a learning point for me on running on multiple files. but evidently, via quick Google, "# pylint: disable=duplicate-code" isn't something that is (easily?) implemented, so, whatever you think is best.... |
The trick is to disable it either in |
No, let's keep it - I think it's worth preserving this change with the scope of this PR. We make API-breaking changes in another one. |
resubmitted for review with reviewer requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback below
resubmitted for review with reviewer comments |
resubmitted with 1 change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.3.12 from 1.3.11: > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#28 from tcfranks/main > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#31 from tekktrik/dev/fix-pylint-errors > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions
resolves #25
submitted for review / comment
Note: in thermal_printer_2168.py the function warm_up accepts an argument "heat_time" and never makes use of it...should it?