Skip to content

mpy zips don't contain mpy files #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FoamyGuy opened this issue May 19, 2023 · 3 comments · Fixed by #37
Closed

mpy zips don't contain mpy files #34

FoamyGuy opened this issue May 19, 2023 · 3 comments · Fixed by #37
Assignees

Comments

@FoamyGuy
Copy link
Contributor

The assets on the release page that are supposed to contain mpy files for the library don't actually contain library files. Instead they contain only the examples:

image

This library is not typically used on devices so it's unlikely many people would be looking for it there, I guess that is why it has gone undiscovered.

I ran across a need to put it on a device to check something and noticed I'm unable to install it circup or grab the mpy files manually from the release assets.

@Neradoc
Copy link

Neradoc commented May 21, 2023

The absence of the mpy files seems to be due to a bug in the new action thing, where packages without the adafruit_ prefix are ignored. I'll open an issue for that.

EDIT: maybe it's not a bug in the action, but a missing parameter in this repo's action.
(see adafruit/Adafruit_CircuitPython_asyncio#41 )

However, I believe the fix here is simply to disable the workflow that creates those zips.
This library should not be used on devices, its absence MUST trigger the except clause in libraries that try to import it.

In fact it can't be run in CP (because of requirements) or even compiled with mpy-cross:

❯ mpy-cross circuitpython_typing/io.py 
Traceback (most recent call last):
  File "circuitpython_typing/io.py", line 43
SyntaxError: invalid syntax

@tekktrik tekktrik self-assigned this May 24, 2023
@tekktrik
Copy link
Member

I can add a disabling input for the workflow, I agree that makes the most sense. It should only disable .mpy zip(s), right?

@tekktrik
Copy link
Member

Alright, ready to make a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants