-
Notifications
You must be signed in to change notification settings - Fork 9
Do not do mpy-cross builds of this library. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree! I'm out until next week, but can happily work on that issue. |
Actually, can't we just use the |
@tekktrik points out we need to do "ignore" in the bundle build, which we can do with existing functionality, but also need an "ignore"-type thing in |
OK, looks good: https://github.com/adafruit/Adafruit_CircuitPython_Typing/releases/tag/1.10.1 has no mpy bundles. Thanks @tekktrik. |
This library is not meant to run on CircuitPython directly. It does need mpy bundles build (they don't work anyway: #34), and now any CI PR build is failing because it's trying to run mpy-cross, but there's some syntax that's not compatible (
def x(a, /):
).Now that we've factored out the build options, I don't see a way to force mpy-cross builds not to be done. There are parameters to the release actions that let you suppress certain bundles from being built, and those should be used. But there is no corresponding parameter in the build action. If you agree, we could open an appropriate issue in https://github.com/adafruit/circuitpython-build-tools.
@FoamyGuy @tekktrik
The text was updated successfully, but these errors were encountered: