Skip to content

Replaced socket.socket instance with calls to WIZNET5K in DNS. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Replaced socket.socket instance with calls to WIZNET5K in DNS. #107

merged 1 commit into from
Apr 19, 2023

Conversation

BiffoBear
Copy link
Contributor

Refactored wiznet5k_dns.py to use calls to WIZNET5K methods instead of wiznet5k_socket.socket which should save memory. Tested with wiznet5k_simpletest.py

dhalbert
dhalbert approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@dhalbert dhalbert merged commit a4b08db into adafruit:main Apr 19, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 20, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a52bbea)
d59baec 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 2.4.1 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#107 from BiffoBear/raw_dns
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#110 from dgnuff/dhcp-buffer-overflow
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#106 from BiffoBear/bugfix_socket_send

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.5.0 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#48 from Neradoc/respond-to-file-head
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#47 from Neradoc/allow-no-route

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@BiffoBear BiffoBear deleted the raw_dns branch May 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BiffoBear @dhalbert