Added explicit soft reset for w5500 initialisation. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
This looks good to me.
I tested this version successfully with a Feather S2 TFT using the simpletest and two server example scripts from this repo.
I'm definitely seeing increased reliability during restarts via ctrl C / ctrl D as well as when files get saved and the device resets itself.
Thanks for this improvement @BiffoBear
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 30, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 2.4.2 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#111 from BiffoBear/fix_w5500_reset Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109 by explicitly resetting the w5500 during initialisation. Tested on w5500 and w5100s for 10
ctrl-Dsoft resets each without raising an exception.