Skip to content

Fix str type annotations to bytes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fix str type annotations to bytes #14

merged 1 commit into from
Mar 28, 2022

Conversation

tekktrik
Copy link
Member

I was type annotating another library and noticed this. I feel like the intention is to use bytes not str given things like the use of chr()

@tekktrik
Fix str type annotations to bytes
10f052e 
I was type annotating another library and noticed this.  I feel like the intention is to use `bytes` not `str` given things like the use of `chr()`
@tekktrik tekktrik added the documentation Improvements or additions to documentation label Mar 25, 2022
@tekktrik tekktrik requested a review from a team March 25, 2022 16:55
FoamyGuy
FoamyGuy approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and looks good to me. Thanks @tekktrik

@FoamyGuy FoamyGuy merged commit 744dbfa into adafruit:main Mar 28, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 29, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d21f7d6)
76b68cd 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#23 from Neradoc/fix-documentation-params
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.0.4 from 5.0.3:
  > Renamed advanced_examples/ to circuitplayground_advanced_examples
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.0.4 from 3.0.3:
  > Renamed advanced_examples/ to clue_advanced_examples/
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.6 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_FONA#16 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#48 from adafruit/pb-cm
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.1.0 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#14 from adafruit/seesawify
  > Fixed readthedocs build

Updating https://github.com/adafruit/Adafruit_CircuitPython_RPLIDAR to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_RPLIDAR#24 from adafruit/adabotify

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.8 from 3.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#46 from Neradoc/fix-documentation-params
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.3.2 from 1.3.1:
  > Rename stmpe610_touch_calibrator_.py to stmpe610_touch_calibrator.py
  > Update and rename touch_calibrator_stmpe610.py to stmpe610_touch_calibrator_.py
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_TFmini to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TFmini#11 from Neradoc/fix-documentation
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.1.2 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#22 from Neradoc/fix-documentation-params-and-code-blocks

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.4 from 5.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#86 from Neradoc/fix-documentation-params-and-code-blocks
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#85 from tekktrik/dev/fix-missing-minimqtt-req

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.2 from 2.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#41 from adafruit/adabotify
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_binascii to 1.2.9 from 1.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_binascii#14 from tekktrik/dev/fix-typing-to-bytes
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.2.3 from 8.2.2:
  > Changed capitalization to satisfy adabot

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.3 from 1.1.2:
  > Renamed client_examples subdir
  > Fixed readthedocs build
  > Post-patch cleanup
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.6.5 from 1.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#43 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.6.2 from 0.6.1:
  > Rename rotaryencoder.py to pioasm_rotaryencoder.py
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#39 from adafruit/adabotify
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.11.4 from 1.11.3:
  > Renamed adafruit_portalbase_simpletest.py to portalbase_simpletest.py
  > Moved example directory to examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @FoamyGuy