Skip to content

CircuitPython_Display_Text: Update for CP7 #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

Remove max_size usage from displayio.Group

Ref: #1603

Changes are need in the Learn Guide: https://learn.adafruit.com/circuitpython-display_text-library/overview

Page: https://learn.adafruit.com/circuitpython-display_text-library/types-of-labels
Section: Most of the page
@FoamyGuy This can have the max_size related comments removed, but the max_glyphs comments need to remain for now. There is a pending PR which will remove max_glyphs - adafruit/Adafruit_CircuitPython_Display_Text#154

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 5f7b939 into adafruit:main Jul 15, 2021
@lesamouraipourpre lesamouraipourpre deleted the cp-display-text branch July 21, 2021 19:16
@lesamouraipourpre
Copy link
Contributor Author

@FoamyGuy Now that max_glyphs has been removed from Display_Text Label, would you be able to rewrite the Learn Guide page below:
https://learn.adafruit.com/circuitpython-display_text-library/types-of-labels

@FoamyGuy
Copy link
Collaborator

Yep, thanks for the pointer. I'm in the process of making a sweep through all of the affected guides to update any references to max_glyphs, max_size, and pixel_shader in any of the code / explanations that don't get pulled from this repo. I will get this one when I am back to working on it this evenning.

@FoamyGuy
Copy link
Collaborator

These guide pages have been updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants