Skip to content
This repository was archived by the owner on Nov 12, 2019. It is now read-only.

add Pi 3b+ support #104

Merged
merged 1 commit into from
Nov 2, 2018
Merged

add Pi 3b+ support #104

merged 1 commit into from
Nov 2, 2018

Conversation

hack-fang
Copy link
Contributor

add support to Pi 3b+,which use 'BCM2837',build succsess

add support to Pi 3b+,which use 'BCM2837',build succsess
@fabaff
Copy link

fabaff commented Nov 2, 2018

Please merge this and create a new release. Thanks.

@brennen
Copy link
Contributor

brennen commented Nov 2, 2018

Tested, seems to be working fine. Release incoming.

@brennen brennen merged commit 1d36090 into adafruit:master Nov 2, 2018
@langestefan
Copy link

Hi, thanks for this fix. Any idea when this will be available in hass.io?

@fabaff
Copy link

fabaff commented Nov 5, 2018

After @brennen created a new release that is available at PyPI.

@langestefan
Copy link

Nice. Any update @brennen ? Still getting the error in hass.io.

@geofbaum
Copy link

@langestefan The latest update to PyPi was on the 7th of November. Not sure why you're getting an error if Hass.io and your setup are using the updated code.

@langestefan
Copy link

@geofbaum Also not sure. Error is still exactly the same so I'm guessing this fix hasn't been included in the most recent release.

@brennen
Copy link
Contributor

brennen commented Nov 19, 2018

The changes in this PR are included in version 1.4.0, uploaded to PyPI (for both the Adafruit_Python_DHT and Adafruit-DHT variants) of the library on the 7th.

That said, having glanced over the issue on home-assistant, I'm not sure whether this would be a fix or not. I'm not familiar with hass.io and haven't tried to test platform detection there.

I have not investigated deeply, but it looks like home-assistant is pinning the library to an earlier release.

(Failing that, it's possible to override the platform and skip platform detection when calling read() or read_retry(). That might be of use but I'm really not familiar with the context this is being used in.)

@langestefan
Copy link

(Failing that, it's possible to override the platform and skip platform detection when calling read() or read_retry(). That might be of use but I'm really not familiar with the context this is being used in.)

I've tried this but I couldn't locate the file raising the error:
File "/usr/local/lib/python3.6/site-packages/Adafruit_DHT/common.py"

Seems there is no folder 'Adafruit_DHT' in my hass.io instance.

@fabaff
Copy link

fabaff commented Dec 6, 2018

Yes, we are pinning the releases. 1.4.0 will be available in the upcoming 0.84 as for 0.83 it was too late.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants