Skip to content

Fix warnings #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2021
Merged

Fix warnings #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7a8b02
use CMSIS-Atmel-1.2.2 to fix LITTLE_ENDIAN warning
hathach May 24, 2021
51bd7a7
better fix warning with "-Wclass-memaccess" in SPI
hathach May 24, 2021
e49dab6
also bump tinyusb
hathach May 24, 2021
33a1e15
increase version to 1.7.1
hathach May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Adafruit_TinyUSB_Arduino
Open in desktop
Submodule Adafruit_TinyUSB_Arduino updated 10 files
+2 −1 README.md
+11 −0 changelog.md
+4 −0 examples/Composite/hid_generic_inout_ramdisk/hid_generic_inout_ramdisk.ino
+4 −0 examples/HID/hid_generic_inout/hid_generic_inout.ino
+7 −0 examples/HID/hid_keyboard/hid_keyboard.ino
+1 −1 library.properties
+5 −4 src/Adafruit_TinyUSB.h
+1 −1 src/arduino/ports/Adafruit_TinyUSB_rp2040.cpp
+1 −1 src/arduino/ports/Adafruit_TinyUSB_samd.cpp
+2 −0 src/osal/osal_pico.h
14 changes: 3 additions & 11 deletions libraries/SPI/SPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,24 +333,16 @@ void SPIClass::dmaAllocate(void) {
use_dma = true; // Everything allocated successfully
extraWriteDescriptors = &extraReadDescriptors[numReadDescriptors];

// dmac.h didn't include extern "C" which cause
// DmacDescriptor and its members are defined as C++ struct therefore
// memcpy will throw warning on copying where simple assignment won't work
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wclass-memaccess"

// Initialize descriptors (copy from first ones)
// cast to void* to suppress warning: with no trivial copy-assignment [-Wclass-memaccess]
for(int i=0; i<numReadDescriptors; i++) {
memcpy(&extraReadDescriptors[i], firstReadDescriptor,
memcpy((void*) &extraReadDescriptors[i], firstReadDescriptor,
sizeof(DmacDescriptor));
}
for(int i=0; i<numWriteDescriptors; i++) {
memcpy(&extraWriteDescriptors[i], firstWriteDescriptor,
memcpy((void*) &extraWriteDescriptors[i], firstWriteDescriptor,
sizeof(DmacDescriptor));
}

#pragma GCC diagnostic pop

} // end malloc
} // end extra descriptor check

Expand Down
4 changes: 2 additions & 2 deletions platform.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5---3rd-party-Hardware-specification

name=Adafruit SAMD (32-bits ARM Cortex-M0+ and Cortex-M4) Boards
version=1.7.0
version=1.7.1

# Compile variables
# -----------------
Expand Down Expand Up @@ -70,7 +70,7 @@ compiler.S.extra_flags=
compiler.ar.extra_flags=
compiler.elf2hex.extra_flags=

compiler.arm.cmsis.c.flags="-I{runtime.tools.CMSIS-5.4.0.path}/CMSIS/Core/Include/" "-I{runtime.tools.CMSIS-5.4.0.path}/CMSIS/DSP/Include/" "-I{runtime.tools.CMSIS-Atmel-1.2.1.path}/CMSIS/Device/ATMEL/"
compiler.arm.cmsis.c.flags="-I{runtime.tools.CMSIS-5.4.0.path}/CMSIS/Core/Include/" "-I{runtime.tools.CMSIS-5.4.0.path}/CMSIS/DSP/Include/" "-I{runtime.tools.CMSIS-Atmel-1.2.2.path}/CMSIS/Device/ATMEL/"
compiler.arm.cmsis.ldflags="-L{runtime.tools.CMSIS-5.4.0.path}/CMSIS/Lib/GCC/" -larm_cortexM0l_math

compiler.libraries.ldflags=
Expand Down