replace CommandLineConfigurationException with InvalidOperationException, fixes dotnet#1909

Author: adamsitnik

src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt

@@ -103,10 +103,6 @@ System.CommandLine
     public System.Boolean EnableTokenReplacement { get; }
     public LocalizationResources LocalizationResources { get; }
     public Command RootCommand { get; }
-  public class CommandLineConfigurationException : System.Exception, System.Runtime.Serialization.ISerializable
-    .ctor(System.String message)
-    .ctor()
-    .ctor(System.String message, System.Exception innerException)
     public System.Void Validate()
   public static class CompletionSourceExtensions
     public static System.Void Add(this CompletionSourceList completionSources, System.Func<System.CommandLine.Completions.CompletionContext,System.Collections.Generic.IEnumerable<System.String>> complete)

src/System.CommandLine.Tests/CommandLineConfigurationTests.cs

@@ -26,7 +26,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_option_aliases_
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException>()
                 .Which
                 .Message
                 .Should()
@@ -54,7 +54,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_option_aliases_
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -79,7 +79,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_subcommand_alia
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -107,7 +107,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_subcommand_alia
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -132,7 +132,7 @@ public void ThrowIfInvalid_throws_if_sibling_command_and_option_aliases_collide_
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -160,7 +160,7 @@ public void ThrowIfInvalid_throws_if_sibling_command_and_option_aliases_collide_
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -183,7 +183,7 @@ public void ThrowIfInvalid_throws_if_there_are_duplicate_sibling_global_option_a
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -239,7 +239,7 @@ public void ThrowIfInvalid_throws_if_a_command_is_its_own_parent()
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()
@@ -258,7 +258,7 @@ public void ThrowIfInvalid_throws_if_a_parentage_cycle_is_detected()
         var validate = () => config.Validate();
 
         validate.Should()
-                .Throw<CommandLineConfigurationException>()
+                .Throw<InvalidOperationException >()
                 .Which
                 .Message
                 .Should()

src/System.CommandLine/CommandLineConfiguration.cs

@@ -117,7 +117,7 @@ private bool DefaultTokenReplacer(
         /// Throws an exception if the parser configuration is ambiguous or otherwise not valid.
         /// </summary>
         /// <remarks>Due to the performance cost of this method, it is recommended to be used in unit testing or in scenarios where the parser is configured dynamically at runtime.</remarks>
-        /// <exception cref="CommandLineConfigurationException">Thrown if the configuration is found to be invalid.</exception>
+        /// <exception cref="InvalidOperationException ">Thrown if the configuration is found to be invalid.</exception>
         public void Validate()
         {
             ThrowIfInvalid(RootCommand);
@@ -126,7 +126,7 @@ static void ThrowIfInvalid(Command command)
             {
                 if (command.Parents.FlattenBreadthFirst(c => c.Parents).Any(ancestor => ancestor == command))
                 {
-                    throw new CommandLineConfigurationException($"Cycle detected in command tree. Command '{command.Name}' is its own ancestor.");
+                    throw new InvalidOperationException($"Cycle detected in command tree. Command '{command.Name}' is its own ancestor.");
                 }
 
                 int count = command.Subcommands.Count + command.Options.Count;
@@ -142,7 +142,7 @@ static void ThrowIfInvalid(Command command)
                             if (symbol1AsIdentifier.Name.Equals(symbol2Alias, StringComparison.Ordinal) ||
                                 symbol1AsIdentifier.Aliases.Contains(symbol2Alias))
                             {
-                                throw new CommandLineConfigurationException($"Duplicate alias '{symbol2Alias}' found on command '{command.Name}'.");
+                                throw new InvalidOperationException($"Duplicate alias '{symbol2Alias}' found on command '{command.Name}'.");
                             }
                         }
                     }