Upgrade to TypeScript 5 #4635
Upgrade to TypeScript 5 #4635
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
examples/rsp-next-ts/pages/_app.tsx
Outdated
| @@ -44,7 +44,7 @@ function MyApp({ Component, pageProps }: AppProps) { | |||
| </ActionButton> | |||
| </Flex> | |||
| <View> | |||
| {/* @ts-ignore */} | |||
| {/* @ts-ignore - https://github.com/vercel/next.js/issues/49610 */} | |||
There was a problem hiding this comment.
Just a heads up but apparently bumping to TS5.1.3 fixed this issue. Fine with keeping this ignore for now anyways since it isn't a RSP issue
There was a problem hiding this comment.
Yeah but then we have the lodash issue I mentioned in the description 🙃
There was a problem hiding this comment.
Ahhh, so we want the project's TS version to exactly match the test app's TS version?
There was a problem hiding this comment.
Ah I can try upgrading just the example to the latest yeah
There was a problem hiding this comment.
I think we can remove our override for ResizeObserver as well?
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-spectrum/utils/src/ResizeObserver.d.ts
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Upgrades to Typescript 5.0.4. 5.1 appears to have one issue breaking the lodash types, which are for some reason loaded (storybook I think). microsoft/TypeScript#53514 DefinitelyTyped/DefinitelyTyped#65674