Skip to content

add: readonly attributes for CalendarCell #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Persists
Copy link
Contributor

Found During Testing

The CalendarCell component was missing the readonly attributes; this PR adds those.

Changes:

  • Adjusted the useCalendarCell hook.
  • Updated the RAC component to apply:
    • data-readonly on the button within the grid cell.
    • aria-readonly on the grid cell element.
  • Added a test

Let me know if there are any further adjustments needed 😃

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@Persists Persists changed the title add: readonly for CalendarCell add: readonly attributes for CalendarCell Apr 10, 2025
@Persists
Copy link
Contributor Author

The data-readonly attribute is currently also missing on the Calendar and RangeCalendar components. I can include it in this PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant