-
-
Notifications
You must be signed in to change notification settings - Fork 50
Made some updates which fixes some of the bugs reported in your issues #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eric-11
wants to merge
15
commits into
adriangibbons:master
Choose a base branch
from
Eric-11:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress to check multisport, etc, but some issues seem to be fixed with the newer enumerated data list.
timeInZones allows for variable number of zone upper boundaries to be passed
Significant changes to $enum_data and $data_mesg_info to accommodate FIT 21.101 with dynamic messages. Decoding dynamic messages has not yet been added or tested. Added debug messages to class for debugging various FIT files.
Added details about newest updates including utility to automatically extract new FIT profile changes in the future.
This is a stand alone tool to read the garmin sdk Profile.xlsx sheets saved as csv. Examples are included in this directory but they should be updated as needed.
example output from readProfileCSV.php for private $enum_data array in phpFitFileAnalysis.php
Example output from readProfileCSV.php for importing into phpFitFileAnalysis.php
FIT files made from Garmin SDK 21.101 including original Profile.xlsx source from https://developer.garmin.com/fit/download/
Fixed formatting and added more clarification.
Some values were not properly setup as integer and the dynamic arrays were updated to be more backwards compatible with the code.
Reflects latest updates to array structures
Latest update to array structures
* Updated handling of enum/mesg arrays. * More debug information to aid in refactoring and adding dynamic fields. * Some minor refactoring of accessing binary file bytes * Added hex_dump to inspect data blocks * Debug mode is extensive while reading data to help refactor some of this code * Ability to detect and process dynamic fields not yet implimented
Hi @Eric-11 thank you so much for all your effort! Was it possible to run the PHPUnit tests successfully? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the fit format to 22.101 and included some utility tools to allow users to make their own updates if the FIT profiles change again.