[ENH] Added test cases for feature based clustering #2690

Ramana-Raja · 2025-03-24T19:30:50Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Added test cases for feature based clustering

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions

I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

For new estimators and functions

I've added the estimator/function to the online API documentation.
(OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.

For developers with write access

(OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

aeon-actions-bot · 2025-03-24T19:31:10Z

Thank you for contributing to `aeon`

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

Run pre-commit checks for all files
Run mypy typecheck tests
Run all pytest tests and configurations
Run all notebook example tests
Run numba-disabled codecov tests
Stop automatic pre-commit fixes (always disabled for drafts)
Disable numba cache loading
Push an empty commit to re-run CI checks

…stering

…tering' into test_case_for_feature_based_clustering

…tering' into test_case_for_feature_based_clustering # Conflicts: # aeon/clustering/feature_based/tests/test_catch22.py # aeon/clustering/feature_based/tests/test_summary.py # aeon/clustering/feature_based/tests/test_tsfresh.py

MatthewMiddlehurst · 2025-03-27T11:59:57Z

Hi, this does not seem to add much that the general testing does not test. It would be better to add any expected results to the testing/ utilities. Cases which are not covered by the general testing are ususally parameters or other model specific functionality. I would check out coverage report to see if there are any uncovered bits.

…tering' into test_case_for_feature_based_clustering # Conflicts: # aeon/clustering/feature_based/tests/test_tsfresh.py

…tering' into test_case_for_feature_based_clustering

Ramana-Raja · 2025-03-27T16:59:11Z

Hi, this does not seem to add much that the general testing does not test. It would be better to add any expected results to the testing/ utilities. Cases which are not covered by the general testing are ususally parameters or other model specific functionality. I would check out coverage report to see if there are any uncovered bits.

Hi, I added extra test cases and made sure they cover 80%+ of the code (except for cases where an estimator is passed), here’s what the tests check:

1.Whether the ARI scores are correct
2.If the output length matches the input length
3.Both Catch22 and Catch24 are tested(using catch24=False)
4.The summary clusterer with all summary stats
5.The TSFresh clusterer with all fc_parameters.
6.That there are no NaN values in the output(when summary clusterer uses all summary stat and when TSFresh clusterer uses all fc parameters) .

Let me know if this is fine or if I should add more.I will use this as a reference for the other 2 PR if it is

MatthewMiddlehurst

Some of these are unnecessarily costly. consider users smaller data.

aeon/clustering/feature_based/tests/test_catch22.py

aeon/clustering/feature_based/tests/test_summary.py

Ramana-Raja · 2025-04-04T13:36:07Z

Some of these are unnecessarily costly. consider users smaller data.

I have reduced the dataset size and removed functions/test cases that are already covered by general tests.

The testing covers the following cases:
1.catch22 is being tested with catch24 set to false
2.Testing with all summary stats for both univariate and multivariate cases for the Summary Clusterer
3.Testing with all FC parameters for both univariate and multivariate cases for the TSFresh Clusterer

TonyBagnall

lgtm, thanks

* Added test cases for feature based clustering * Automatic `pre-commit` fixes * added docstring * Automatic `pre-commit` fixes * added . * added . * updated tsfresh * Automatic `pre-commit` fixes * added pytest _check_soft_dependencies for tsfresh * Automatic `pre-commit` fixes * added more testing * Automatic `pre-commit` fixes * added docs * added docs * added pytest * Automatic `pre-commit` fixes * improved docs * Automatic `pre-commit` fixes * improved test cases * changes made as requested by moderators * changes made as requested by moderators * Automatic `pre-commit` fixes * changed "percentiles" to "quantiles" --------- Co-authored-by: Ramana-Raja <[email protected]> Co-authored-by: Matthew Middlehurst <[email protected]> Co-authored-by: Tony Bagnall <[email protected]>

* add difference transformer to series transformations * add myself to .all-contributorsrc * small modification * modify according to reviews * [ENH] add informational tags back to estimator docs (#2652) * feat: add new tags information for anomaly detection * feat: add tag information in given anomaly modles * fix: add new anomaly detector tags in mock anomaly detector class * fix: use anomaly-detector instead of estimator for new tags * update and add basic testing * fixes --------- Co-authored-by: MatthewMiddlehurst <[email protected]> * [DOC] Documentation improvement of BaseSeriesEstimator and BaseAeonEstimator (#2612) * Added the docs for base series and base classes * Updated documentation for base classes --------- Co-authored-by: Matthew Middlehurst <[email protected]> * [ENH] HydraTransformer Output changed (#2656) * output type added * hydra wflow modified * hydra test file added * pr_pytest reverted * soft dep check added * soft dep corrected * docstring corrected, enhanced test cases * [DOC] Improved Hidalgo Segmentation Notebook (#2616) * Improved Hidalgo Segmentation Notebook * Updated hidalgo notebook --------- Co-authored-by: Matthew Middlehurst <[email protected]> * new devs and workflow consolidation (#2797) * all branches (#2809) * Automated `pre-commit` hook update (#2820) Co-authored-by: TonyBagnall <[email protected]> * [MNT] Bump crs-k/stale-branches in the github-actions group (#2821) Bumps the github-actions group with 1 update: [crs-k/stale-branches](https://github.com/crs-k/stale-branches). Updates `crs-k/stale-branches` from 7.0.1 to 8.1.1 - [Release notes](https://github.com/crs-k/stale-branches/releases) - [Commits](crs-k/stale-branches@v7.0.1...v8.1.1) --- updated-dependencies: - dependency-name: crs-k/stale-branches dependency-version: 8.1.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: indexing in kdtw (#2826) * [ENH] Added test cases for feature based clustering (#2690) * Added test cases for feature based clustering * Automatic `pre-commit` fixes * added docstring * Automatic `pre-commit` fixes * added . * added . * updated tsfresh * Automatic `pre-commit` fixes * added pytest _check_soft_dependencies for tsfresh * Automatic `pre-commit` fixes * added more testing * Automatic `pre-commit` fixes * added docs * added docs * added pytest * Automatic `pre-commit` fixes * improved docs * Automatic `pre-commit` fixes * improved test cases * changes made as requested by moderators * changes made as requested by moderators * Automatic `pre-commit` fixes * changed "percentiles" to "quantiles" --------- Co-authored-by: Ramana-Raja <[email protected]> Co-authored-by: Matthew Middlehurst <[email protected]> Co-authored-by: Tony Bagnall <[email protected]> * [DOC] Fix inconsistent double backticks in updated similarity_search module docstrings (#2618) * delete some descriptions * modification to _maintainer_ --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Matthew Middlehurst <[email protected]> Co-authored-by: Tony Bagnall <[email protected]> Co-authored-by: Adarsh Dubey <[email protected]> Co-authored-by: Kevin Shah <[email protected]> Co-authored-by: Balgopal Moharana <[email protected]> Co-authored-by: Kavya Rambhia <[email protected]> Co-authored-by: aeon-actions-bot[bot] <148872591+aeon-actions-bot[bot]@users.noreply.github.com> Co-authored-by: TonyBagnall <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Schmidl <[email protected]> Co-authored-by: Ramana Raja <[email protected]> Co-authored-by: Ramana-Raja <[email protected]> Co-authored-by: Ciph3r <[email protected]>

Added test cases for feature based clustering

bef0d8f

Ramana-Raja requested review from chrisholder and TonyBagnall as code owners March 24, 2025 19:30

Ramana-Raja changed the title ~~Added test cases for feature based clustering~~ [ENH] Added test cases for feature based clustering Mar 24, 2025

aeon-actions-bot bot added clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement labels Mar 24, 2025

Ramana-Raja and others added 8 commits March 24, 2025 19:32

Merge branch 'aeon-toolkit:main' into test_case_for_feature_based_clu…

9db9e92

…stering

Automatic pre-commit fixes

7de55cb

added docstring

f39fdca

Merge remote-tracking branch 'origin/test_case_for_feature_based_clus…

a753660

…tering' into test_case_for_feature_based_clustering

Automatic pre-commit fixes

abaf016

added .

4e6df5f

added .

2f0f89e

MatthewMiddlehurst added the codecov actions Run the codecov action on a PR label Mar 24, 2025

Ramana-Raja and others added 4 commits March 25, 2025 01:31

updated tsfresh

882d5bb

Automatic pre-commit fixes

05c3186

added pytest _check_soft_dependencies for tsfresh

9c12732

Automatic pre-commit fixes

278c6b9

MatthewMiddlehurst mentioned this pull request Mar 27, 2025

[ENH] Added Test Cases For convolution based-Classification #2691

Draft

5 tasks

Ramana-Raja and others added 8 commits March 27, 2025 20:45

added more testing

4d222c9

Automatic pre-commit fixes

8a59ffb

added docs

1e5cee8

Merge remote-tracking branch 'origin/test_case_for_feature_based_clus…

6539699

…tering' into test_case_for_feature_based_clustering # Conflicts: # aeon/clustering/feature_based/tests/test_tsfresh.py

added docs

e7b6d93

added pytest

77d70a6

Automatic pre-commit fixes

3605dd5

improved docs

4b3d76f

Ramana-Raja and others added 4 commits March 27, 2025 21:28

Merge remote-tracking branch 'origin/test_case_for_feature_based_clus…

d7f4c38

…tering' into test_case_for_feature_based_clustering

Automatic pre-commit fixes

f1a8f88

improved test cases

af4be41

Merge remote-tracking branch 'origin/test_case_for_feature_based_clus…

ee74e23

…tering' into test_case_for_feature_based_clustering

MatthewMiddlehurst approved these changes Apr 4, 2025

View reviewed changes

MatthewMiddlehurst requested changes Apr 4, 2025

View reviewed changes

aeon/clustering/feature_based/tests/test_catch22.py Outdated Show resolved Hide resolved

aeon/clustering/feature_based/tests/test_catch22.py Outdated Show resolved Hide resolved

aeon/clustering/feature_based/tests/test_summary.py Outdated Show resolved Hide resolved

Ramana-Raja and others added 3 commits April 4, 2025 18:15

changes made as requested by moderators

0644583

changes made as requested by moderators

559ffb1

Automatic pre-commit fixes

9c0a1c1

Ramana-Raja requested a review from MatthewMiddlehurst April 4, 2025 16:43

Merge branch 'main' into test_case_for_feature_based_clustering

d235715

MatthewMiddlehurst previously approved these changes May 1, 2025

View reviewed changes

Ramana-Raja mentioned this pull request May 4, 2025

[DOC] Change SummaryClusterer's summary_stats to match with SevenNumberSummary's summary_stats #2777

Closed

changed "percentiles" to "quantiles"

127df38

Ramana-Raja dismissed MatthewMiddlehurst’s stale review via 127df38 May 5, 2025 11:49

Ramana-Raja and others added 2 commits May 5, 2025 20:39

Merge branch 'main' into test_case_for_feature_based_clustering

40d38fe

Merge branch 'main' into test_case_for_feature_based_clustering

9f255ea

TonyBagnall approved these changes May 18, 2025

View reviewed changes

TonyBagnall merged commit bf38e63 into aeon-toolkit:main May 21, 2025
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ENH] Added test cases for feature based clustering #2690

[ENH] Added test cases for feature based clustering #2690

Uh oh!

Ramana-Raja commented Mar 24, 2025 •

edited

Loading

Uh oh!

aeon-actions-bot bot commented Mar 24, 2025

Uh oh!

MatthewMiddlehurst commented Mar 27, 2025

Uh oh!

Ramana-Raja commented Mar 27, 2025 •

edited

Loading

Uh oh!

MatthewMiddlehurst left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ramana-Raja commented Apr 4, 2025 •

edited

Loading

Uh oh!

TonyBagnall left a comment

Uh oh!

Uh oh!

Uh oh!

[ENH] Added test cases for feature based clustering #2690

[ENH] Added test cases for feature based clustering #2690

Uh oh!

Conversation

Ramana-Raja commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions

For new estimators and functions

For developers with write access

Uh oh!

aeon-actions-bot bot commented Mar 24, 2025

Thank you for contributing to aeon

PR CI actions

Uh oh!

MatthewMiddlehurst commented Mar 27, 2025

Uh oh!

Ramana-Raja commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ramana-Raja commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TonyBagnall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Ramana-Raja commented Mar 24, 2025 •

edited

Loading

Thank you for contributing to `aeon`

Ramana-Raja commented Mar 27, 2025 •

edited

Loading

Ramana-Raja commented Apr 4, 2025 •

edited

Loading