N-gram character models #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redblobgames
requested changes
Oct 12, 2017
| @@ -5,18 +5,34 @@ | |||
| <link rel="stylesheet" href="../styles.css"> | |||
| <script src="http://code.jquery.com/jquery-1.12.4.js"></script> | |||
| <script type="text/javascript" src="../main.js"></script> | |||
| <script type="text/javascript" src="../22-Natural-Language-Processing/nGramModels.js"></script> | |||
There was a problem hiding this comment.
This can be simpler as src="nGramModels.js"
| <button type="submit" class="submit btn btn-success">Submit</button> | ||
| </div> | ||
| </form> | ||
| <span><h5>Character Level Unigrams :-</h5></span><div id="character-level-unigram"></div><br> |
There was a problem hiding this comment.
A span is an “inline element” and an h5 is a “block element”. Normally a block element can contain inline elements, but inline elements should not contain block elements. I think you can remove the span here
|
Bug: try entering some text, click submit, then click submit again. It duplicates the text. |
|
@redblobgames i think now its all working correctly. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with reference to #103 .