Emit class components to circumvent defaultProps warnings
#131
Conversation
react is deprecating defaultProps, so we'll emit class components instead to avoid it
src/index.js
Outdated
| var SVG_NAME = function SVG_NAME(props) { React.PureComponent.call(this, props); }; | ||
| SVG_NAME.prototype = Object.create(React.PureComponent.prototype); | ||
| SVG_NAME.prototype.constructor = SVG_NAME; | ||
| SVG_NAME.prototype.render = function render() { var props = this.props; return SVG_CODE; }; |
There was a problem hiding this comment.
this seems very strange; only class components are pure.
There was a problem hiding this comment.
wdym? whats expected here? 🤔 want me to change it to React.Component?
There was a problem hiding this comment.
afaik this is a class component, only thing its not doing its being strict about how babel compiles a class to a function (eg, doing constructor call checks)
There was a problem hiding this comment.
If it's not using class syntax, then i'd expect it to use https://www.npmjs.com/package/create-react-class
There was a problem hiding this comment.
oh.. nice, react big monorepo without docs with the only docs linked being broken..
I'll assume this is the same createReactClass and rely on old docs and use it then
There was a problem hiding this comment.
@ljharb, I've made the switch, can you check the current changes now?
I'm changing the code emission so that it emits class components so that we don't get
defaultPropsdeprecated warnings anymoreThis is all based on this suggestion here #129 (comment) but since that would change the fundamental idea behind the PR (still emit functions but use assign to merge defaultProps + use a flag at the plugin level to preserve behavior), I'm opening a new one
And to make it clear: we're aware that, at least in NextJS, SSR does not support class components, but we'll consider that a fault of NextJS itself.