Add licenses to sub packages #1746
Conversation
There was a problem hiding this comment.
This isn't really necessary; the SPDX-compliant "license" field in package.json notes that it's MIT, and that's sufficient due to https://github.com/airbnb/javascript/blob/master/LICENSE.md.
However, this seems fine.
|
@ljharb Thank you! While I'm no lawyer myself, I think although the package is a product of the repository with a license text, it is still necessary to accompany the package with a full license text, as it is distributed separately. And the MIT license requires the full license text to be alongside the code. Will link this as well: babel/babel#7308 (comment) |
|
@ljharb btw, are you planning a new release? |
|
The next release will be breaking (due to other merged changes); I’m not going to backport a patch release just for this. |
|
Separately, the point of a SPDX-compliant identifier, as i understand it, is that the license text is no longer relevant or needed because it is uniquely identified by the license identifier (which implies license text). Maybe @kemitchell can confirm, or correct me if I’m wrong? |
I didn't think of it like that. It was more like whether you have an idea when the next release might happen. |
|
No idea, but hopefully soon. |
Fix #1744. Not sure how to trigger patch release, couldn't find any contributing docs. Please advise.
Replaces #1745