Replace flag images with emoji #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use emoji for most of these flags, which should make them look better on higher resolution displays and improve the loading performance of the style guide a little. The only flag we have here that does not have a good emoji yet is the flag of Catalonia, which I left as-is for now. https://emojipedia.org/flag-for-catalonia-esct/
|
Does Github handle rendering these properly on browsers and devices that lack proper emoji support? |
|
Looking at the source code in my inspector, it looks like it probably does. Here's what it renders for the Brazil flag: <g-emoji class="g-emoji" alias="brazil" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f1e7-1f1f7.png">🇧🇷</g-emoji> |
ljharb
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use emoji for most of these flags, which should make
them look better on higher resolution displays and improve the
loading performance of the style guide a little.
The only flag we have here that does not have a good emoji yet
is the flag of Catalonia, which I left as-is for now.
https://emojipedia.org/flag-for-catalonia-esct/