Updated Arrays Section #1854
Merged
Updated Arrays Section #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- corrected paragraph 4.4 (conversion from iterable to array) - added paragraph 4.5 (conversion from array-like to array)
ljharb
requested changes
Jul 4, 2018
README.md
Outdated
| @@ -369,8 +369,8 @@ Other Style Guides | |||
| const itemsCopy = [...items]; | |||
| ``` | |||
|
|
|||
| <a name="arrays--from"></a><a name="4.4"></a> | |||
| - [4.4](#arrays--from) To convert an array-like object to an array, use spreads `...` instead of [`Array.from`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/from). | |||
| <a name="arrays--from-iterable"></a><a name="4.4"></a> | |||
There was a problem hiding this comment.
we'll need to keep an <a name="arrays--from"></a> so that existing links don't break.
README.md
Outdated
| @@ -382,8 +382,21 @@ Other Style Guides | |||
| const nodes = [...foo]; | |||
| ``` | |||
|
|
|||
| <a name="arrays--mapping"></a> | |||
| - [4.5](#arrays--mapping) Use [Array.from](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/from) instead of spread `...` for mapping over iterables, because it avoids creating an intermediate array. | |||
| <a name="arrays--from-array-like"></a><a name="4.5"></a> | |||
There was a problem hiding this comment.
there's no need to add this 4.5 anchor here; numbered links are legacy
README.md
Outdated
| @@ -393,8 +406,8 @@ Other Style Guides | |||
| const baz = Array.from(foo, bar); | |||
| ``` | |||
|
|
|||
| <a name="arrays--callback-return"></a><a name="4.5"></a> | |||
| - [4.6](#arrays--callback-return) Use return statements in array method callbacks. It’s ok to omit the return if the function body consists of a single statement returning an expression without side effects, following [8.2](#arrows--implicit-return). eslint: [`array-callback-return`](https://eslint.org/docs/rules/array-callback-return) | |||
| <a name="arrays--callback-return"></a><a name="4.7"></a> | |||
There was a problem hiding this comment.
and none of the others section's links should be renumbered.
maurozenoni
force-pushed
the
arrays-spreads
branch
from
99d08f6 to
c6cd43b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1851