zoxide with file paths #1017
Open
zoxide with file paths #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users to use file paths to change their current directory to that file's parent directory as per #1015.
The intended behavior of
z foo/bar.bazwould be to change their cwd into the directory matchingfoo/.This PR accomplishes this by mapping over
self.keywordsinQuery::get_stream.Warning
Introduces the method
transformed_keywordsonQuerywhich is called every time a query command is run, and a several heap allocation for each keyword.More importantly, it does not modify
self.keywords, meaning any uses ofself.keywordsalong the query control flow after the stream is constructed won't match up with the stream.As far as I can tell though, there are no such usages.