New Bookmark Command #1019
Open
New Bookmark Command #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove old bookmark dir fix: move stream test imports feat: bookmark completions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new subcommand called
bookmarkas per #1014Usage
zoxide bookmark foo ~/barcreates a bookmark in the database calledfoowhich aliases tobar.Then,
zoxide query fooautomatically outputs~/barbefore even opening aStream. However, it doesn't match, sozoxide query foooignores the bookmarking system and matchesdirsonfooo.This PR restructures the database, by turning
dirsinto a tuple containing the olddirs(a vector of directories) and a bookmarks hashmap. They must be under the same field so they can be serialized and deserialized together, while obeying theself_referencingstruct system.Warning
Because of this restructuring, old databases will no longer be deserializable.
However, this PR also adds additional code to the deserialize command, which will fall back on deserializing just the vector of
Dirs, then reserializing the database with those dirs and an empty hashmap.So existing zoxide instances should still operate perfectly, but old databases will be changed.