Upgrade to babel 7 #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
bable-7
branch
3 times, most recently
from
449fe67 to
097a9e6
Compare
|
Looks like there are some known flow bugs around imports causing the CI failures i.e. facebook/flow#7069 |
added 2 commits
November 6, 2018 16:43
Unblock consumers updating to Babel 7 which patches some bugs that can prevent some users updating to Node 10.
|
This upgrade is causing all kinds of weird and wonderful changes :( |
|
@xzyfer Thanks for PR. I'll try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Unblock consumers updating to Babel 7
Why:
Babel 7 patches some bugs that prevent can prevent some users updating to Node 10.
babel-plugin-react-intlmade this upgrade also formatjs/babel-plugin-react-intl#145How:
This work was mostly machine translated using the babel-upgrade tool
Checklist:
This is a breaking change.
May also make sense to make the same changes to
extract-react-intl-messagesgiven it's referenced in the documentation. I'm happy to make those changes also.