Fuzz: verify that roundtripping f64 through string results in the same value #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! What is the random float64 generator used by the fuzzer? I.e. would it often emit super large and super small floats? (in case it does you might also use ryu serializer because it will use scientific notation and standard library's to-string will not - thus giving you free code paths). |
It will, if it notices that they trigger different code paths. I'll copy the ryu setup from the exhaustive f32 roundtrip test and see if that changes anything. |
|
Thanks! |
|
@Shnatsel I kicked off fuzz testing 4 months ago and totally forgot about it... 1.1 trillion checks for each of the fuzz tests... I think it's safe to say it's safe enough 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.