Skip to content

Use H5Pisa_class to circumvent bug #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

mulimoen
Copy link
Collaborator

@mulimoen mulimoen commented Sep 5, 2022

Fixes #218. On the the bug in the issue memory usage decreases from 100MB++ to less than 50kB

@stormmathisen and @smutch Would be great if you tested this

@mulimoen mulimoen requested a review from aldanor September 5, 2022 17:03
@smutch
Copy link

smutch commented Sep 6, 2022

Hi @mulimoen. Thanks for looking in to this.

I can confirm a noticeable improvement for my small test run (3,819 groups with ~11,500 datasets).

Before:
Screen Shot 2022-09-06 at 10 57 00

After:
Screen Shot 2022-09-06 at 10 57 24

There is a large reduction in persistent 96 byte allocations.

@aldanor
Copy link
Owner

aldanor commented Sep 28, 2022

  • Probably makes sense to fix a few clippy complaints as well here?
  • Add this to changelog?
  • Why do you say it "partially" fixes Memory Leak in Dataset Creation #218? Wasn't this the root of the problem?

@mulimoen
Copy link
Collaborator Author

There are enough breaking clippy complaints that I've opened #220 for those.

Added an entry to the changelog and changed the description of this PR

@aldanor
Copy link
Owner

aldanor commented Oct 17, 2022

Rebase on master?

@aldanor
Copy link
Owner

aldanor commented Oct 17, 2022

👍

@mulimoen mulimoen merged commit fb96296 into aldanor:master Oct 17, 2022
@mulimoen mulimoen deleted the bugfix/class_leak branch October 17, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Leak in Dataset Creation
3 participants