Skip to content

Exposed the CURLOPT_UPLOAD_BUFFERSIZE curl option. #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Exposed the CURLOPT_UPLOAD_BUFFERSIZE curl option. #411

merged 4 commits into from
Oct 1, 2021

Conversation

darkprokoba
Copy link
Contributor

@alexcrichton
Copy link
Owner

Looks good but I believe there's some CI errors.

@darkprokoba
Copy link
Contributor Author

darkprokoba commented Sep 30, 2021

CI / Test (system-curl) (pull_request) Failing after 2m — Test (system-curl)

I guess this CI test uses libcurl earlier than 7.62.0...
Perhaps in the test at tests/easy.rs:303 I could check the libcurl version and skip the h.upload_buffer_size(10) call?

if Version::get().version_num() >= 0x073e00 { // only available on 7.62.0 and later
    t!(h.upload_buffer_size(10));
}

Not sure how to go about this :-)

@alexcrichton
Copy link
Owner

Conditionally testing the version is fine, but it looks like you'll also need to update systest/build.rs with conditionally checking the constant itself.

@darkprokoba
Copy link
Contributor Author

All checks have passed

Whew :-)

@alexcrichton alexcrichton merged commit ecc8a2b into alexcrichton:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants