Skip to content

fix(types): allow mix of strings and arrays in facetFilters #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix(types): allow mix of strings and arrays in facetFilters #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/client-search/src/types/DeleteByFiltersOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type DeleteByFiltersOptions = {
/**
* Filter hits by facet value.
*/
readonly facetFilters?: string | readonly string[] | ReadonlyArray<readonly string[]>;
readonly facetFilters?: string | readonly string[] | ReadonlyArray<readonly string[] | string>;

/**
* Filter on numeric attributes.
Expand Down
2 changes: 1 addition & 1 deletion packages/client-search/src/types/SearchOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export type SearchOptions = {
/**
* Filter hits by facet value.
*/
readonly facetFilters?: string | readonly string[] | ReadonlyArray<readonly string[]>;
readonly facetFilters?: string | readonly string[] | ReadonlyArray<readonly string[] | string>;

/**
* Create filters for ranking purposes, where records that match the filter are ranked highest.
Expand Down