-
Notifications
You must be signed in to change notification settings - Fork 223
feat(recommend): Add trending types and methods #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
36bbcfc
feat(recommend): Add trending types and methods
SophieManley03 727c787
fix(recommend): Add a trendingQuery type
SophieManley03 b1f7794
feat(recommend): increase bundle size
SophieManley03 d64940d
fix: remove TrendingType
SophieManley03 4014f29
Merge branch 'feat/recommend-trending' of github.com:algolia/algolias…
SophieManley03 0d304e6
fix: remove items for facet as in the search and use it within trendi…
SophieManley03 3567914
Merge branch 'master' into feat/recommend-trending
shortcuts a1d7636
fix: reintroduce trendingQuery
SophieManley03 cfe8fc5
Merge branch 'feat/recommend-trending' of github.com:algolia/algolias…
SophieManley03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ | |
}, | ||
{ | ||
"path": "packages/recommend/dist/recommend.umd.js", | ||
"maxSize": "4.1KB" | ||
"maxSize": "4.2KB" | ||
} | ||
] | ||
} |
46 changes: 46 additions & 0 deletions
46
packages/recommend/src/__tests__/getTrendingFacets.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import { TestSuite } from '../../../client-common/src/__tests__/TestSuite'; | ||
|
||
const recommend = new TestSuite('recommend').recommend; | ||
|
||
function createMockedClient() { | ||
const client = recommend('appId', 'apiKey'); | ||
jest.spyOn(client.transporter, 'read').mockImplementation(() => Promise.resolve()); | ||
|
||
return client; | ||
} | ||
|
||
describe('getTrendingFacets', () => { | ||
test('builds the request', async () => { | ||
const client = createMockedClient(); | ||
|
||
await client.getTrendingFacets( | ||
[ | ||
{ | ||
indexName: 'products', | ||
facetName: 'company', | ||
}, | ||
], | ||
{} | ||
); | ||
|
||
expect(client.transporter.read).toHaveBeenCalledTimes(1); | ||
expect(client.transporter.read).toHaveBeenCalledWith( | ||
{ | ||
cacheable: true, | ||
data: { | ||
requests: [ | ||
{ | ||
indexName: 'products', | ||
model: 'trending-facets', | ||
facetName: 'company', | ||
threshold: 0, | ||
}, | ||
], | ||
}, | ||
method: 'POST', | ||
path: '1/indexes/*/recommendations', | ||
}, | ||
{} | ||
); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { TestSuite } from '../../../client-common/src/__tests__/TestSuite'; | ||
|
||
const recommend = new TestSuite('recommend').recommend; | ||
|
||
function createMockedClient() { | ||
const client = recommend('appId', 'apiKey'); | ||
jest.spyOn(client.transporter, 'read').mockImplementation(() => Promise.resolve()); | ||
|
||
return client; | ||
} | ||
|
||
describe('getTrendingItems', () => { | ||
test('builds the request', async () => { | ||
const client = createMockedClient(); | ||
|
||
await client.getTrendingItems( | ||
[ | ||
{ | ||
indexName: 'products', | ||
}, | ||
], | ||
{} | ||
); | ||
|
||
expect(client.transporter.read).toHaveBeenCalledTimes(1); | ||
expect(client.transporter.read).toHaveBeenCalledWith( | ||
{ | ||
cacheable: true, | ||
data: { | ||
requests: [ | ||
{ | ||
indexName: 'products', | ||
model: 'trending-items', | ||
threshold: 0, | ||
}, | ||
], | ||
}, | ||
method: 'POST', | ||
path: '1/indexes/*/recommendations', | ||
}, | ||
{} | ||
); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { MethodEnum } from '@algolia/requester-common'; | ||
|
||
import { BaseRecommendClient, TrendingFacetsQuery, WithRecommendMethods } from '../types'; | ||
|
||
type GetTrendingFacets = ( | ||
base: BaseRecommendClient | ||
) => WithRecommendMethods<BaseRecommendClient>['getTrendingFacets']; | ||
|
||
export const getTrendingFacets: GetTrendingFacets = base => { | ||
return (queries: readonly TrendingFacetsQuery[], requestOptions) => { | ||
const requests: readonly TrendingFacetsQuery[] = queries.map(query => ({ | ||
...query, | ||
model: 'trending-facets', | ||
// The `threshold` param is required by the endpoint to make it easier | ||
// to provide a default value later, so we default it in the client | ||
// so that users don't have to provide a value. | ||
shortcuts marked this conversation as resolved.
Show resolved
Hide resolved
|
||
threshold: query.threshold || 0, | ||
})); | ||
|
||
return base.transporter.read( | ||
{ | ||
method: MethodEnum.Post, | ||
path: '1/indexes/*/recommendations', | ||
data: { | ||
requests, | ||
}, | ||
cacheable: true, | ||
}, | ||
requestOptions | ||
); | ||
}; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { MethodEnum } from '@algolia/requester-common'; | ||
|
||
import { BaseRecommendClient, TrendingItemsQuery, WithRecommendMethods } from '../types'; | ||
|
||
type GetTrendingItems = ( | ||
base: BaseRecommendClient | ||
) => WithRecommendMethods<BaseRecommendClient>['getTrendingItems']; | ||
|
||
export const getTrendingItems: GetTrendingItems = base => { | ||
return (queries: readonly TrendingItemsQuery[], requestOptions) => { | ||
const requests: readonly TrendingItemsQuery[] = queries.map(query => ({ | ||
...query, | ||
model: 'trending-items', | ||
// The `threshold` param is required by the endpoint to make it easier | ||
// to provide a default value later, so we default it in the client | ||
// so that users don't have to provide a value. | ||
threshold: query.threshold || 0, | ||
})); | ||
|
||
return base.transporter.read( | ||
{ | ||
method: MethodEnum.Post, | ||
path: '1/indexes/*/recommendations', | ||
data: { | ||
requests, | ||
}, | ||
cacheable: true, | ||
}, | ||
requestOptions | ||
); | ||
}; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1 +1,2 @@ | ||||||||||
export type RecommendModel = 'related-products' | 'bought-together'; | ||||||||||
export type RecommendModel = 'related-products' | 'bought-together' | TrendingModel; | ||||||||||
export type TrendingModel = 'trending-items' | 'trending-facets'; | ||||||||||
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry D: #1399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { TrendingQuery } from './TrendingQuery'; | ||
|
||
export type TrendingFacetsQuery = Omit<TrendingQuery, 'model' | 'facetValue'>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { TrendingQuery } from './TrendingQuery'; | ||
|
||
export type TrendingItemsQuery = Omit<TrendingQuery, 'model'>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import { TrendingModel } from './RecommendModel'; | ||
import { RecommendSearchOptions } from './RecommendSearchOptions'; | ||
|
||
export type TrendingQuery = { | ||
/** | ||
* The name of the target index. | ||
*/ | ||
readonly indexName: string; | ||
|
||
/** | ||
* The name of the Recommendation model to use. | ||
*/ | ||
readonly model: TrendingModel; | ||
|
||
/** | ||
* Threshold for the recommendations confidence score (between 0 and 100). Only recommendations with a greater score are returned. | ||
*/ | ||
readonly threshold?: number; | ||
|
||
/** | ||
* How many recommendations to retrieve. | ||
*/ | ||
readonly maxRecommendations?: number; | ||
|
||
/** | ||
* List of [search parameters](https://www.algolia.com/doc/api-reference/search-api-parameters/) to send. | ||
*/ | ||
readonly queryParameters?: RecommendSearchOptions; | ||
|
||
/** | ||
* List of [search parameters](https://www.algolia.com/doc/api-reference/search-api-parameters/) to send. | ||
* | ||
* Additional filters to use as fallback when there aren’t enough recommendations. | ||
*/ | ||
readonly fallbackParameters?: RecommendSearchOptions; | ||
|
||
/** | ||
* Used for trending model | ||
*/ | ||
readonly facetName?: string; | ||
|
||
/** | ||
* Used for trending model | ||
*/ | ||
readonly facetValue?: string; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.