Skip to content

chore(js): test invalid parameter errors #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-275

Changes included:

  • Add some tests to check invalid parameter error

🧪 Test

@eunjae-lee eunjae-lee changed the title fix(js): add client tests chore(js): test errors Jan 27, 2022
@eunjae-lee eunjae-lee changed the title chore(js): test errors chore(js): test invalid parameter errors Jan 27, 2022
@eunjae-lee
Copy link
Contributor Author

We generate methods based on json, and generate code to throw errors when something is missing. So, instead of generating test code for throwing errors, I manually wrote some tests to see if all that flow works fine. This isn't a complete set, but more like a smoke test.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants