chore(ci): validate pull-request title #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
force-pushed
the
chore/pr-title2
branch
from
25bee61 to
2c9083f
Compare
eunjae-lee
commented
Feb 11, 2022
Comment on lines
+29
to
+30
| with: | ||
| regex: '^(?:(feat)|(fix)|(docs)|(style)|(refactor)|(perf)|(test)|(build)|(ci)|(chore)|(revert))\((?:(javascript)|(php)|(java)|(cts)|(spec)|(script)|(ci))\): .+' |
There was a problem hiding this comment.
I added ci as a scope. What do you think?
There was a problem hiding this comment.
Next improvement could be to find the languages with a small bash script but it's fine for now
eunjae-lee
changed the title
|
Having an other workflow does not stop other jobs to run, we could maybe set this at the early stage of our CI https://github.com/algolia/api-clients-automation/blob/main/.github/workflows/check.yml |
eunjae-lee
commented
Feb 11, 2022
eunjae-lee
changed the title
This reverts commit d4afd07.
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
* chore(ci): validate pr title * chore: remove semantic pull request config * chore: fix name of workflow * chore: clean up workflow * chore: move title checking to check.yml * Revert "chore: move title checking to check.yml" This reverts commit d4afd07. * chore: remove unnecessary setup
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-305
Changes included: