-
Notifications
You must be signed in to change notification settings - Fork 21
feat(php): Model cleaning #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the current PHP client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you don't think model are useful ?
Is there a way to make them useful by typing parameters ?
Is it possible to only type the response and not the params ?
Passing arrays as parameters make sense in PHP, it is how it's done right now in the current client https://github.com/algolia/algoliasearch-client-php/blob/master/src/SearchIndex.php and globally PHP developers are more used to pass arrays in methods. |
Is it not possible to wrap the response or convert it to the correct type ? It helps so much during development |
🧭 What and Why
🎟 JIRA Ticket: APIC-304
Changes included:
🧪 Test