Skip to content

chore(ci): refine release process #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

chore(ci): refine release process #237

wants to merge 8 commits into from

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-360

Changes included:

  • Remove submodule-related code
  • Clone each repositories under temp folder, copy changes, and push

🧪 Test

  • CI

@netlify
Copy link

netlify bot commented Mar 7, 2022

✔️ Deploy Preview for api-clients-automation ready!

🔨 Explore the source changes: d293c9a

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/62272a730fd7a00007c968ad

😎 Browse the preview: https://deploy-preview-237--api-clients-automation.netlify.app

@eunjae-lee
Copy link
Contributor Author

https://github.com/eunjae-lee/api-clients-automation/runs/5452001866?check_suite_focus=true

It almost worked, but failed only because there was a tag with the same version in the js repository. Currently, the versioning is wrong here, which should be fixed in a separate PR.

@shortcuts
Copy link
Member

shortcuts commented Mar 7, 2022

Currently, the versioning is wrong here, which should be fixed in a separate PR.

It is actually right for the beta, we should just avoid updating tags on the algoliasearch-client-javascript repository side for now.

Maybe we could have a beta check? (and probably deploy beta tags on this repository?)

@shortcuts
Copy link
Member

I forgot that GA does not work from forks :( could you re-open the PR from a local branch?

@eunjae-lee eunjae-lee closed this Mar 8, 2022
@eunjae-lee
Copy link
Contributor Author

continued in #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants