-
Notifications
You must be signed in to change notification settings - Fork 21
chore: fix bad revision on main
branch
#246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 2afadd3 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622f036057b55a0008c6909d |
main
branchmain
branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good !
|
||
- name: Compute specs matrix | ||
id: spec-matrix | ||
shell: bash | ||
run: | | ||
base_changed=${{ github.ref == 'refs/heads/main' || steps.diff.outputs.GITHUB_ACTIONS_CHANGED > 0 || steps.diff.outputs.SCRIPTS_CHANGED > 0 || steps.diff.outputs.COMMON_SPECS_CHANGED > 0 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.ref == 'refs/heads/main'
This code was to always run everything on main, do we don't want that anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly wanted to fix the error thrown to make it clearer, but we can indeed either:
- properly run everything on main
- only run relevant checks
IMO every steps should run on release trigger, but we don't need to run unrelated jobs on merge
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
base_ref
does not exists onmain
, which makes the CI fails to run thegit diff
and run all tasks even when no changes are related.see -> setup -> setup
🧪 Test
CI :D