Skip to content

chore: fix bad revision on main branch #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2022
Merged

chore: fix bad revision on main branch #246

merged 3 commits into from
Mar 14, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 9, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

base_ref does not exists on main, which makes the CI fails to run the git diff and run all tasks even when no changes are related.

see -> setup -> setup

🧪 Test

CI :D

@shortcuts shortcuts requested review from eunjae-lee and damcou March 9, 2022 18:07
@shortcuts shortcuts self-assigned this Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 2afadd3

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622f036057b55a0008c6909d

@shortcuts shortcuts changed the title ci: fix bad revision on main branch chore: fix bad revision on main branch Mar 9, 2022
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !


- name: Compute specs matrix
id: spec-matrix
shell: bash
run: |
base_changed=${{ github.ref == 'refs/heads/main' || steps.diff.outputs.GITHUB_ACTIONS_CHANGED > 0 || steps.diff.outputs.SCRIPTS_CHANGED > 0 || steps.diff.outputs.COMMON_SPECS_CHANGED > 0 }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.ref == 'refs/heads/main'
This code was to always run everything on main, do we don't want that anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly wanted to fix the error thrown to make it clearer, but we can indeed either:

  • properly run everything on main
  • only run relevant checks

IMO every steps should run on release trigger, but we don't need to run unrelated jobs on merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants