chore: fix bad revision on main branch
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 2afadd3 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622f036057b55a0008c6909d |
shortcuts
changed the title
main branchmain branch
millotp
approved these changes
Mar 14, 2022
|
|
||
| - name: Compute specs matrix | ||
| id: spec-matrix | ||
| shell: bash | ||
| run: | | ||
| base_changed=${{ github.ref == 'refs/heads/main' || steps.diff.outputs.GITHUB_ACTIONS_CHANGED > 0 || steps.diff.outputs.SCRIPTS_CHANGED > 0 || steps.diff.outputs.COMMON_SPECS_CHANGED > 0 }} |
There was a problem hiding this comment.
github.ref == 'refs/heads/main'
This code was to always run everything on main, do we don't want that anymore ?
There was a problem hiding this comment.
I mostly wanted to fix the error thrown to make it clearer, but we can indeed either:
- properly run everything on main
- only run relevant checks
IMO every steps should run on release trigger, but we don't need to run unrelated jobs on merge
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
base_refdoes not exists onmain, which makes the CI fails to run thegit diffand run all tasks even when no changes are related.see -> setup -> setup
🧪 Test
CI :D