-
Notifications
You must be signed in to change notification settings - Fork 21
chore(ci): push to each repository on PR merge #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 73e3c04 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/623895a7d69e860008b6a31a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!!
✗ The generated branch has been deleted. If the PR has been merged, you can check the generated code on the |
Not sure why this error is happening. Any idea @shortcuts ? 🤔 |
Because the checkout is sync with main, and the script does not exist on main You can set it to this branch for the PR review, and then re-do a PR with an update for main |
ahah good catch |
@shortcuts Your comment got me realized that this |
Indeed, and should also contain this clause: |
I didn't know about this. I'll apply it here soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good!!! Only one last comment :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goooood!
* chore(ci): push to each repository on PR merge * chore: separate spreadGeneration workflow * chore: remove unnecessary eslint disable comment * chore: rename workflow * chore: adjust abstraction * chore: include PR url in commit message * chore: move generation workflow to after codegen * chore: spread generation only on main * chore: spread generation only when codegen is successful * chore: spread generation as a part of codegen * chore: apply author name and email to commits * chore: include coauthor in commit message * chore: add tests * chore: add tests
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-371
Changes included:
Every time a PR is merged on monorepo, GitHub Action pushes the generated clients to each repository.
If a commit is language specific, for example,
fix(javascript): ...
, then only the js repo receives the commit (with the same commit message).If a commit is common for all the languages, all the language repos receive the commit.
🧪 Test