-
Notifications
You must be signed in to change notification settings - Fork 21
chore(ci): remove the option to just update repository #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted. If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this option not needed anymore ?
Context here @millotp |
scripts/release/process-release.ts
Outdated
await run(`git push --tags`, { cwd: tempGitDir }); | ||
} | ||
await execa('git', ['tag', `v${next}`], { cwd: tempGitDir }); | ||
await run(`git push --tags`, { cwd: tempGitDir }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a pro of git tags at all, but it seems weird to have git push
twice, and --tags
should be avoided according to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I didn't know that option. aab519c
* chore(ci): remove the option to just update repository * chore: remove temporary test condition * chore: push once
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-388
Changes included: