docs: generate guides from snippets #3139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
changed the title
millotp
reviewed
Jun 10, 2024
|
|
||
|
|
||
| </TabsLanguage> | ||
| ${waitForTaskSnippet()} |
There was a problem hiding this comment.
this should be waitForAppTaskSnippet but let's tackle this in another PR
There was a problem hiding this comment.
because its only used for dict, should we call it waitForDictionary ?
There was a problem hiding this comment.
I'm not sure maybe we missed some use cases, let's keep the legacy name for safety
millotp
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2429 https://algolia.atlassian.net/browse/DI-2409 https://algolia.atlassian.net/browse/DI-1632 https://algolia.atlassian.net/browse/APIC-679
Changes included:
provide the snippet methods directly in the docs guides, so you can generate a guide for all clients, in one go
todo: