Skip to content

chore: prevent running jobs on cancel #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Follow up of #253

As seen on https://github.com/algolia/api-clients-automation/actions/runs/2101479001 cancelled jobs are not considered as failure, this should fix the condition.

I've tried to remove the always condition by early exiting jobs, but it's not supported in GitHub actions yet actions/runner#662

🧪 Test

CI :D

@shortcuts shortcuts requested a review from millotp April 6, 2022 12:13
@shortcuts shortcuts self-assigned this Apr 6, 2022
@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit c1eed6f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/624d8533bd6f490730c95a55

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 6, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts enabled auto-merge (squash) April 6, 2022 12:26
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants