feat(java): add algolia user agent APIC-338 #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
eunjae-lee and
shortcuts
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Apr 7, 2022
|
|
||
| The version is optional for segments. | ||
|
|
||
| The resulting User Agent is the concatenation of `base`, `client`, and all the `segments`. |
There was a problem hiding this comment.
Maybe an example of output could help
|
|
||
| public String addSegment(Segment seg) { | ||
| String segment = seg.toString(); | ||
| if (segments.contains(segment)) return finalValue; |
There was a problem hiding this comment.
non blocking: I did not saw other one liners in this codebase, we might want to stick to curly brackets for consistency
This was referenced Apr 11, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-338
Add User-Agent specification in the doc to always have the same format,
and implement it in the java client, as an optional parameter.
🧪 Test
Test the ua in the playground by adding a
System.out.println(ua.toString())in theApiClient.javaconstructor.