Skip to content

chore: use js scripts to set output variables #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 7, 2022

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Convert bash logic to a ts script, which should behave the same way, but easier to maintain.

Closes #351 as it works the same as before

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team April 7, 2022 12:27
@shortcuts shortcuts self-assigned this Apr 7, 2022
@shortcuts shortcuts requested review from eunjae-lee and damcou and removed request for a team April 7, 2022 12:27
@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 6d5b961
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/624ef68118ce930502c38799

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 7, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script ! now do the same with cache 😛

@shortcuts
Copy link
Member Author

Nice script ! now do the same with cache 😛

:(

@shortcuts shortcuts enabled auto-merge (squash) April 7, 2022 14:45
@shortcuts shortcuts requested a review from millotp April 7, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants