Skip to content

fix: strip java client #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2022
Merged

fix: strip java client #42

merged 4 commits into from
Jan 4, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 15, 2021

🧭 What and Why

Strip the java client to remove all unused code and useless functionality.
I think a lot of code can still be removed, but this is already a big PR.

Changes included:

  • Removed unused mustache files
  • Remove swagger related stuff in the java code
  • Remove some duplicate doc (like the response for each endpoint)
  • Remove unused library (joda, threeten, bean)
  • Remove cookies
  • Remove ssl certificates
  • Remove file download
  • Rename local variables
  • Simplify api calls

🧪 Test

yarn docker playground:java

@millotp millotp self-assigned this Dec 15, 2021
@shortcuts
Copy link
Member

I already like what I'm seeing here

@millotp millotp marked this pull request as ready for review January 4, 2022 15:16
@millotp millotp requested review from damcou and shortcuts January 4, 2022 15:16
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is pretty big but easy to review, it's good to go on my side! GG :D

I'd ask a small overview from @aallam on some random files, just to see if he have any comments on the shape of the current client

@millotp
Copy link
Collaborator Author

millotp commented Jan 4, 2022

I'd ask a small overview from @aallam on some random files, just to see if he have any comments on the shape of the current client

I think it's still early, I haven't changed the http client or anything yet, just simplifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants