Skip to content

fix(ci): compute the correct hash #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2022
Merged

fix(ci): compute the correct hash #438

merged 7 commits into from
Apr 27, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 27, 2022

🧭 What and Why

#433 didn't compute the correct hash, it's way easier to do it manually than trying to automate it in the array of dependencies.

Changes included:

  • Compute hash correctly for GA, scripts and config
  • Merge hash with node crypto
  • Add algoliasearch-lite job as dependency of the cts

🧪 Test

CI

@millotp millotp self-assigned this Apr 27, 2022
@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 96eab03
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626932083eb1d30008e2f842

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 27, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@millotp millotp requested a review from shortcuts April 27, 2022 11:01
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good! Small comment on the deps

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one last one D:

@@ -106,6 +93,28 @@ const VARIABLES_TO_CHECK: Array<{
},
];

async function computeCommonHash(): Promise<string> {
const hashGA = await hashElement('../.github', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok last comment I swear: do we maybe want to use the toAbsolutePath fn here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want ahah, the CI is flaky anyway there will be some merge later

shortcuts
shortcuts previously approved these changes Apr 27, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good! Nice

@millotp millotp enabled auto-merge (squash) April 27, 2022 11:42
@millotp millotp disabled auto-merge April 27, 2022 11:43
@millotp millotp requested a review from shortcuts April 27, 2022 12:30
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants