-
Notifications
You must be signed in to change notification settings - Fork 21
fix(ci): compute the correct hash #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good! Small comment on the deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry one last one D:
scripts/ci/setRunVariables.ts
Outdated
@@ -106,6 +93,28 @@ const VARIABLES_TO_CHECK: Array<{ | |||
}, | |||
]; | |||
|
|||
async function computeCommonHash(): Promise<string> { | |||
const hashGA = await hashElement('../.github', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok last comment I swear: do we maybe want to use the toAbsolutePath
fn here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want ahah, the CI is flaky anyway there will be some merge later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good! Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
🧭 What and Why
#433 didn't compute the correct hash, it's way easier to do it manually than trying to automate it in the array of dependencies.
Changes included:
algoliasearch-lite
job as dependency of the cts🧪 Test
CI