Skip to content

fix(js): make http(s) agent global #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix(js): make http(s) agent global #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0743717
fix(js): make http(s) agent global
shortcuts Dec 16, 2021
5fba1dc
add comment
shortcuts Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions clients/algoliasearch-client-javascript/client-analytics/utils/requester/HttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ import type { EndRequest, Response } from '../types';

import { Requester } from './Requester';

export class HttpRequester extends Requester {
private httpAgent: http.Agent;
private httpsAgent: https.Agent;

constructor() {
super();
this.httpAgent = new http.Agent({ keepAlive: true });
this.httpsAgent = new https.Agent({ keepAlive: true });
}
// Global agents allow us to reuse the TCP protocol with multiple clients
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);

export class HttpRequester extends Requester {
send(request: EndRequest): Promise<Response> {
return new Promise((resolve) => {
let responseTimeout: NodeJS.Timeout | undefined;
Expand All @@ -24,7 +20,7 @@ export class HttpRequester extends Requester {
const path =
url.search === null ? url.pathname : `${url.pathname}${url.search}`;
const options: https.RequestOptions = {
agent: url.protocol === 'https:' ? this.httpsAgent : this.httpAgent,
agent: url.protocol === 'https:' ? httpsAgent : httpAgent,
hostname: url.hostname,
path,
method: request.method,
Expand Down
16 changes: 6 additions & 10 deletions ...s/algoliasearch-client-javascript/client-personalization/utils/requester/HttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ import type { EndRequest, Response } from '../types';

import { Requester } from './Requester';

export class HttpRequester extends Requester {
private httpAgent: http.Agent;
private httpsAgent: https.Agent;

constructor() {
super();
this.httpAgent = new http.Agent({ keepAlive: true });
this.httpsAgent = new https.Agent({ keepAlive: true });
}
// Global agents allow us to reuse the TCP protocol with multiple clients
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);

export class HttpRequester extends Requester {
send(request: EndRequest): Promise<Response> {
return new Promise((resolve) => {
let responseTimeout: NodeJS.Timeout | undefined;
Expand All @@ -24,7 +20,7 @@ export class HttpRequester extends Requester {
const path =
url.search === null ? url.pathname : `${url.pathname}${url.search}`;
const options: https.RequestOptions = {
agent: url.protocol === 'https:' ? this.httpsAgent : this.httpAgent,
agent: url.protocol === 'https:' ? httpsAgent : httpAgent,
hostname: url.hostname,
path,
method: request.method,
Expand Down
16 changes: 6 additions & 10 deletions clients/algoliasearch-client-javascript/client-search/utils/requester/HttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ import type { EndRequest, Response } from '../types';

import { Requester } from './Requester';

export class HttpRequester extends Requester {
private httpAgent: http.Agent;
private httpsAgent: https.Agent;

constructor() {
super();
this.httpAgent = new http.Agent({ keepAlive: true });
this.httpsAgent = new https.Agent({ keepAlive: true });
}
// Global agents allow us to reuse the TCP protocol with multiple clients
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);

export class HttpRequester extends Requester {
send(request: EndRequest): Promise<Response> {
return new Promise((resolve) => {
let responseTimeout: NodeJS.Timeout | undefined;
Expand All @@ -24,7 +20,7 @@ export class HttpRequester extends Requester {
const path =
url.search === null ? url.pathname : `${url.pathname}${url.search}`;
const options: https.RequestOptions = {
agent: url.protocol === 'https:' ? this.httpsAgent : this.httpAgent,
agent: url.protocol === 'https:' ? httpsAgent : httpAgent,
hostname: url.hostname,
path,
method: request.method,
Expand Down
16 changes: 6 additions & 10 deletions clients/algoliasearch-client-javascript/recommend/utils/requester/HttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ import type { EndRequest, Response } from '../types';

import { Requester } from './Requester';

export class HttpRequester extends Requester {
private httpAgent: http.Agent;
private httpsAgent: https.Agent;

constructor() {
super();
this.httpAgent = new http.Agent({ keepAlive: true });
this.httpsAgent = new https.Agent({ keepAlive: true });
}
// Global agents allow us to reuse the TCP protocol with multiple clients
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);

export class HttpRequester extends Requester {
send(request: EndRequest): Promise<Response> {
return new Promise((resolve) => {
let responseTimeout: NodeJS.Timeout | undefined;
Expand All @@ -24,7 +20,7 @@ export class HttpRequester extends Requester {
const path =
url.search === null ? url.pathname : `${url.pathname}${url.search}`;
const options: https.RequestOptions = {
agent: url.protocol === 'https:' ? this.httpsAgent : this.httpAgent,
agent: url.protocol === 'https:' ? httpsAgent : httpAgent,
hostname: url.hostname,
path,
method: request.method,
Expand Down
16 changes: 6 additions & 10 deletions clients/algoliasearch-client-javascript/utils/requester/HttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@ import type { EndRequest, Response } from '../types';

import { Requester } from './Requester';

export class HttpRequester extends Requester {
private httpAgent: http.Agent;
private httpsAgent: https.Agent;

constructor() {
super();
this.httpAgent = new http.Agent({ keepAlive: true });
this.httpsAgent = new https.Agent({ keepAlive: true });
}
// Global agents allow us to reuse the TCP protocol with multiple clients
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);

export class HttpRequester extends Requester {
send(request: EndRequest): Promise<Response> {
return new Promise((resolve) => {
let responseTimeout: NodeJS.Timeout | undefined;
Expand All @@ -24,7 +20,7 @@ export class HttpRequester extends Requester {
const path =
url.search === null ? url.pathname : `${url.pathname}${url.search}`;
const options: https.RequestOptions = {
agent: url.protocol === 'https:' ? this.httpsAgent : this.httpAgent,
agent: url.protocol === 'https:' ? httpsAgent : httpAgent,
hostname: url.hostname,
path,
method: request.method,
Expand Down