Skip to content

chore(scripts): use java 22 for tooling #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2025
Merged

chore(scripts): use java 22 for tooling #4480

merged 5 commits into from
Feb 20, 2025

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 19, 2025

🧭 What and Why

The java version at the root of the repo is for tooling only, nothing is stopping us to be up-to-date.

Use zulu locally since this is what we use on the CI.

@millotp millotp self-assigned this Feb 19, 2025
@millotp millotp requested a review from a team as a code owner February 19, 2025 10:28
@millotp millotp requested review from Fluf22 and shortcuts February 19, 2025 10:28
@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 19, 2025

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1670
javascript 1651
csharp 1474
php 1458
java 1138
python 1131
ruby 799
swift 764

shortcuts
shortcuts previously approved these changes Feb 19, 2025
@shortcuts
Copy link
Member

ah everything is red

shortcuts
shortcuts previously approved these changes Feb 19, 2025
@millotp millotp changed the title chore(scripts): use java 23 for tooling chore(scripts): use java 22 for tooling Feb 20, 2025
@millotp millotp requested a review from shortcuts February 20, 2025 08:57
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no java lsp/linter to detect improvements from 17 to 22?

@millotp
Copy link
Collaborator Author

millotp commented Feb 20, 2025

I looked at the changelog but nothing obvious, maybe better switch cases or lambda

@millotp millotp enabled auto-merge (squash) February 20, 2025 12:32
@millotp millotp merged commit 3e15c83 into main Feb 20, 2025
28 checks passed
@millotp millotp deleted the chore/java-23 branch February 20, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants