Skip to content

fix(specs): update Recommend maxRecommendations to 30 max [RECO-2361] #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Feb 20, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/RECO-2361

Changes included:

  • In Recommend maxRecommendations parameter should go from 1 to 30.

🧪 Test

N/A

@raed667 raed667 requested a review from a team as a code owner February 20, 2025 10:41
@raed667 raed667 requested review from Fluf22 and shortcuts February 20, 2025 10:41
@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 20, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 13ec24e1165e36b41fe05b1377dc24febd088bff
🍃 Generated commit 668d97ad4bbe3293da71d710af220a9e3a916ec0
🌲 Generated branch generated/fix/recommend/maxRecommendations-30
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 770

@raed667 raed667 changed the title fix(recommend): update maxRecommendations to 30 max [RECO-2361] fix(specs): update Recommend maxRecommendations to 30 max [RECO-2361] Feb 20, 2025
@shortcuts shortcuts enabled auto-merge (squash) February 20, 2025 10:43
@millotp millotp disabled auto-merge February 20, 2025 10:49
@millotp
Copy link
Collaborator

millotp commented Feb 20, 2025

there is a bug with the guides @raed667, it's not an issue with your PR, it will be fixed after #4484

@shortcuts shortcuts enabled auto-merge (squash) February 20, 2025 14:38
@shortcuts shortcuts merged commit 4f68190 into main Feb 20, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/recommend/maxRecommendations-30 branch February 20, 2025 14:50
@raed667
Copy link
Contributor Author

raed667 commented Feb 20, 2025

Thank you both @shortcuts & @millotp for your responsiveness 🙏

algolia-bot added a commit that referenced this pull request Feb 20, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Feb 20, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants