Skip to content

fix(clients): implement Is on custom errors [skip-e2e] #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 11, 2025

🧭 What and Why

This allow users to use errors.Is on our custom errors

@millotp millotp self-assigned this Mar 11, 2025
@millotp millotp requested a review from a team as a code owner March 11, 2025 16:55
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 11, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 6d00f92945657f49a2c1bd7a8e14c594eae50db6
🍃 Generated commit a05f328e1ea75fa775c697f8b9b0352e83c3a732
🌲 Generated branch generated/fix/go-is
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1602

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆🏻‍♂️

@millotp millotp enabled auto-merge (squash) March 11, 2025 16:57
@millotp millotp changed the title fix(clients): implement Is on custom errors fix(clients): implement Is on custom errors [skip-e2e] Mar 11, 2025
@millotp millotp merged commit 7e5e124 into main Mar 11, 2025
12 checks passed
@millotp millotp deleted the fix/go-is branch March 11, 2025 18:10
algolia-bot added a commit that referenced this pull request Mar 11, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants