fix(specs): New Crawler API parameter - ignorePaginationAttributes #4614
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
|
||
| It doesn't replace: | ||
|
|
||
|
|
There was a problem hiding this comment.
are all of those spaces expected?
There was a problem hiding this comment.
Double spacing makes sure paragraphs render properly and spacing between list elements stops them running into each other
There was a problem hiding this comment.
I don't think it's necessary for specs in this repo as you can see with the other API specs. The sources don't have this formatting, but in the generated, complete specs, you'll find the double spacing. Maybe something to do with YAML parsing/writing.
There was a problem hiding this comment.
In the source, you'll notice that long description fields are declared as literal block scalars with the | symbol, which means keep newlines as indicated.
During the bundling of the spec, and I don't know why, most of these are converted into folded block scalars with the > symbol, which means newlines are replaced by a space, two newlines are replaced by one newline.
I find the | style more readable as it leads to more compact blocks
There was a problem hiding this comment.
I'll keep an eye on this when the bundle is built. I did notice some discrepancies in spacing that I manually corrected for the Mintlify prototype.
|
Popping this on hold for now. I've just spotted some duplication in my updates... |
…4614) (generated) [skip ci] Co-authored-by: gazconroy <[email protected]> Co-authored-by: Gary Conroy <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
🧭 What and Why
New configuration parameter added to the Crawler API.
Changes included:
ignorePaginationAttributesparameternumbertypes tointegertypes