Skip to content

chore: deprecate mcm methods #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2025
Merged

chore: deprecate mcm methods #4694

merged 6 commits into from
Apr 1, 2025

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Apr 1, 2025

🧭 What and Why

MCM is deprecated from April 1, 2025.
Marking these operations as deprecated for the docs.

(I hope this just affects doc strings for the client methods)

🎟 JIRA Ticket Confluence page: https://algolia.atlassian.net/browse/DI-3648 RAPID multi-cluster sunset

Changes included:

  • Add deprecated fields to each operation with the 'Clusters' tag
  • Update the description of the 'Clusters' tag

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 1, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 28f846efa3ca4562fbb8de665ebdd81807db7271
🍃 Generated commit 8ed4db1b19bfcb55d5313c7269ce173cb2d39876
🌲 Generated branch generated/chore/deprecate-mcm
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1642
go 1632
php 1499
csharp 1352
java 1097
python 1091
ruby 745
swift 320
scala 23

@kai687 kai687 marked this pull request as ready for review April 1, 2025 08:29
@kai687 kai687 requested a review from a team as a code owner April 1, 2025 08:29
@kai687 kai687 requested review from morganleroi and shortcuts April 1, 2025 08:29
@shortcuts
Copy link
Member

ah Nice I had a task to do it!

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the templates so they all support deprecation notice 🥶

@kai687
Copy link
Contributor Author

kai687 commented Apr 1, 2025

@shortcuts sorry. Didn't want to take away your work :).

@shortcuts
Copy link
Member

@shortcuts sorry. Didn't want to take away your work :).

no worries that's great that you started it!!

@kai687
Copy link
Contributor Author

kai687 commented Apr 1, 2025

Added @deprecated tag (or related comment) to templates for Kotlin, Ruby, Scala, and JavaScript. Templates for other languages include this information if I looked correctly.

@kai687 kai687 requested a review from shortcuts April 1, 2025 10:43
@shortcuts
Copy link
Member

Added @deprecated tag (or related comment) to templates for Kotlin, Ruby, Scala, and JavaScript. Templates for other languages include this information if I looked correctly.

🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!!!!!

@shortcuts shortcuts merged commit a516830 into main Apr 1, 2025
28 checks passed
@shortcuts shortcuts deleted the chore/deprecate-mcm branch April 1, 2025 12:00
algolia-bot added a commit that referenced this pull request Apr 1, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 1, 2025
algolia/api-clients-automation#4694

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Kai Welke <[email protected]>
Co-authored-by: shortcuts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants